Messages in this thread | | | Subject | Re: [PATCH] Scheduler Profiling - Use Immediate Values | From | Andi Kleen <> | Date | 08 Sep 2007 18:12:27 +0200 |
| |
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> writes: > > - profile_hit(SCHED_PROFILING, __builtin_return_address(0)); > + immediate_if (&sched_profiling)
I must say I really dislike immediate_if(). You complained earlier that something breaks coloring, but adding such macros will definitely break a lot of editors (especially if you use it without {} like here)
It would be much nicer and readable to just use if (unlikely(immediate_read(&x)) or if you prefer to hide the unlikely if (immediate_bool_test(&x)) with an implicit unlikely().
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |