Messages in this thread | | | Subject | Re: [PATCH 0/2] Fix (improve) deadlock condition on module removal netfilter socket option removal | From | Rusty Russell <> | Date | Thu, 06 Sep 2007 02:13:26 +1000 |
| |
On Wed, 2007-09-05 at 17:22 +0200, Patrick McHardy wrote: > But I'm wondering, wouldn't module refcounting alone fix this problem? > If we make nf_sockopt() call try_module_get(ops->owner), remove_module() > on ip_tables.ko would simply fail because the refcount is above zero > (so it would fail at point 3 above). Am I missing something important?
Yes, that seems the correct solution to me, too. ISTR that this code predates the current module code.
Rusty.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |