| Date | Mon, 03 Sep 2007 19:43:51 +0900 | From | Masahide NAKAMURA <> | Subject | Re: [-mm patch] IPV6 must select XFRM |
| |
Hello,
On Sun, 2 Sep 2007 13:25:57 +0200 Adrian Bunk <bunk@kernel.org> wrote:
> On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote: > >... > > Changes since 2.6.23-rc3-mm1: > >... > > git-net.patch > >... > > git trees > >... > > This patch fixes the following compile error: > > <-- snip --> > > ... > LD .tmp_vmlinux1 > net/built-in.o: In function `inet6_csk_xmit': > (.text+0x72b0f): undefined reference to `flow_cache_genid' > net/built-in.o: In function `inet6_csk_xmit': > (.text+0x72be5): undefined reference to `flow_cache_genid' > make[1]: *** [.tmp_vmlinux1] Error 1 > > <-- snip --> > > Signed-off-by: Adrian Bunk <bunk@kernel.org> > > --- > --- a/net/ipv6/Kconfig > +++ b/net/ipv6/Kconfig > @@ -5,6 +5,7 @@ > # IPv6 as module will cause a CRASH if you try to unload it > config IPV6 > tristate "The IPv6 protocol" > + select XFRM > default m > ---help--- > This is complemental support for the IP version 6. > > -
Thank you for catching this. the issue is caused with patch "[IPV6] XFRM: Fix connected socket to use transformation." which I sent to netdev. (a85d5450ddeb959bdf9e4603f9c06e9d79217cfa on net-2.6.24).
I'd prefer to modify the original patch to use "ifdef CONFIG_XFRM" than changing kernel config depends. Does it make sense?
Please review the attached patch.
-- Masahide NAKAMURA [unhandled content-type:application/octet-stream] |