lkml.org 
[lkml]   [2007]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] module: return error when mod_sysfs_init() failed
    load_module() returns zero when mod_sysfs_init() fails,
    then the module loading will succeed accidentally.

    This patch makes load_module() return error correctly in that case.

    Cc: Greg Kroah-Hartman <gregkh@suse.de>
    Cc: Rusty Russell <rusty@rustcorp.com.au>
    Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>

    ---
    kernel/module.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    Index: 2.6-git/kernel/module.c
    ===================================================================
    --- 2.6-git.orig/kernel/module.c
    +++ 2.6-git/kernel/module.c
    @@ -1782,7 +1782,8 @@ static struct module *load_module(void _
    module_unload_init(mod);

    /* Initialize kobject, so we can reference it. */
    - if (mod_sysfs_init(mod) != 0)
    + err = mod_sysfs_init(mod);
    + if (err)
    goto cleanup;

    /* Set up license info based on the info section */
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-09-29 12:13    [W:0.023 / U:0.120 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site