Messages in this thread | | | Date | Sat, 29 Sep 2007 11:29:28 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine |
| |
On Sat, 29 Sep 2007 03:51:56 -0700 Andrew Morton wrote:
> On Sat, 29 Sep 2007 12:25:30 +0200 Jean Delvare <khali@linux-fr.org> wrote: > > > Remove a not particularly relevant rule from CodingStyle. > > Sometimes, printing numbers in parentheses doesn't add value, but in > > some (most?) cases it makes the message easier to read. As a matter of > > fact, this practice is widely used in the kernel: > > > > linux-2.6.23-rc8$ quilt grep -I '(%l*[du])' | wc -l > > 3166 > > linux-2.6.23-rc8$ > > > > Signed-off-by: Jean Delvare <khali@linux-fr.org> > > --- > > Documentation/CodingStyle | 2 -- > > 1 file changed, 2 deletions(-) > > > > --- linux-2.6.23-rc8.orig/Documentation/CodingStyle 2007-07-23 16:44:32.000000000 +0200 > > +++ linux-2.6.23-rc8/Documentation/CodingStyle 2007-09-28 23:53:23.000000000 +0200 > > @@ -638,8 +638,6 @@ concise, clear, and unambiguous. > > > > Kernel messages do not have to be terminated with a period. > > > > -Printing numbers in parentheses (%d) adds no value and should be avoided. > > - > > There are a number of driver model diagnostic macros in <linux/device.h> > > which you should use to make sure messages are matched to the right device > > and driver, and are tagged with the right level: dev_err(), dev_warn(), > > I wonder how that got there.
http://linux.bkbits.net:8080/linux-2.6/?PAGE=cset&REV=4034429a6JsOCMNXT3tTPAX1kX40bg
Let's kill it, please. (i.e., ACK)
--- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |