lkml.org 
[lkml]   [2007]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mm1 1/2] fixing idr_find() locking
On Fri, 28 Sep 2007 08:31:44 +0200 Jarek Poplawski <jarkao2@o2.pl> wrote:

> On Thu, Sep 27, 2007 at 04:33:55PM +0200, Nadia.Derbey@bull.net wrote:
> > [PATCH 01/02]
> >
> >
> > This is a patch that fixes the way idr_find() used to be called in ipc_lock():
> > in all the paths that don't imply an update of the ipcs idr, it was called
> > without the idr tree being locked.
> >
> > The changes are:
> > . in ipc_ids, the mutex has been changed into a reader/writer semaphore.
> > . ipc_lock() now takes the mutex as a reader during the idr_find().
> > . a new routine ipc_lock_down() has been defined: it doesn't take the
> > mutex, assuming that it is being held by the caller. This is the routine
> > that is now called in all the update paths.
> >
> >
> > Signed-off-by: Nadia Derbey <Nadia.Derbey@bull.net>
>
> Acked-by: Jarek Poplawski <jarkao2@o2.pl>

thanks.

> PS: there is one big mistake around To/Cc ordering, so I doubt Andrew
> will ever sign this...

Noe, I received and applied it earlier today.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-09-28 08:43    [W:0.065 / U:1.904 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site