Messages in this thread | | | From | akepner@sgi ... | Date | Thu, 27 Sep 2007 17:27:34 -0700 | Subject | Re: [PATCH 0/4] allow drivers to flush in-flight DMA |
| |
On Wed, Sep 26, 2007 at 12:49:50AM -0600, Grant Grundler wrote:
[edited out several points that I think have been already addresed by others in this thread.]
> .... > Defining it terms of completion queues won't mean much to most folks. > Better to add a description of completion queues to the DMA-API.txt if > necessary. dma_alloc_coherent() API is pretty well understood.
OK, next time I'll use a more generic description.
> > > There are four patches in this set: > > > > [1/4] dma: add dma_flags_set_dmaflush() to dma interface > > Sorry - this feels like a "color of the shed" argument, but isn't > this about DMA ordering attribute? > "dmaflush" is an action and not an attribute to me.
Right - an attribute is a noun, not a verb. I'm going to try "s/dmaflush/dmabarrier/" in the next version.
> .... > This patch updates Documentation/DMA-mapping.txt. But it's a change to > the generic (not PCI specific) API described in DMA-API.txt. > Can you update that as well please? >....
Ja, I realized that soon after hitting the send button. I'll move the documentation to DMA-API.txt.
-- Arthur
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |