Messages in this thread | | | Date | Thu, 27 Sep 2007 12:37:15 -0700 | From | Randy Dunlap <> | Subject | Re: 2.6.23-rc8-mm2: problems on HP nx6325 |
| |
On Thu, 27 Sep 2007 21:48:59 +0200 Rafael J. Wysocki wrote:
> On Thursday, 27 September 2007 21:19, Sam Ravnborg wrote: > > On Thu, Sep 27, 2007 at 10:33:51AM -0700, Randy Dunlap wrote: > > > On Thu, 27 Sep 2007 18:53:46 +0200 Sam Ravnborg wrote: > > > > > > > Hi Rafael. > > > > > > > > > > Fix CPU hotplug breakage on HP nx6325 and similar boxes caused by a reference > > > > > to disable_apic_timer (labeled as __initdata) from the CPU initialization code. > > > > > > > > > > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> > > > > > --- > > > > > arch/x86_64/kernel/apic.c | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > Index: linux-2.6.23-rc8-mm2/arch/x86_64/kernel/apic.c > > > > > =================================================================== > > > > > --- linux-2.6.23-rc8-mm2.orig/arch/x86_64/kernel/apic.c > > > > > +++ linux-2.6.23-rc8-mm2/arch/x86_64/kernel/apic.c > > > > > @@ -42,7 +42,7 @@ > > > > > > > > > > int apic_verbosity; > > > > > static int apic_calibrate_pmtmr __initdata; > > > > > -int disable_apic_timer __initdata; > > > > > +int disable_apic_timer __cpuinitdata; > > > > > > > > > This is with your configuration a reference from a .text section > > > > to a .init.data section as I see it. > > > > > > > > So this ought to have been flagged by the section mismatch > > > > checks in modpost. > > > > > > > > I assume you did not see such warning?? > > > > > > I did: > > But I didn't. I'm not sure why.
I did only on one build machine (multiple times). I tried to reproduce it on another machine and could not. I blame different build tools.
> > > WARNING: vmlinux.o(.text+0x7778): Section mismatch: reference to .init.data:disable_apic_timer (between 'identify_cpu' and 'IRQ0x20_interrupt') > > > > Thanks. I look forward to the day I can make them errors so people > > cannot ignore them. > > That said a lot of individuals has done a very good job getting > > rid of section mismatch warnings all over the kernel. > > Yes.
--- ~Randy Phaedrus says that Quality is about caring. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |