Messages in this thread | | | Date | Wed, 26 Sep 2007 10:15:34 +0200 | From | Bernhard Walle <> | Subject | Re: [patch 5/7] Use extended crashkernel command line on ppc64 |
| |
Hi,
* Andrew Morton <akpm@linux-foundation.org> [2007-09-25 21:45]: > On Tue, 25 Sep 2007 20:23:02 +0200 Bernhard Walle <bwalle@suse.de> wrote: > > > This patch adapts the ppc64 code to use the generic parse_crashkernel() > > function introduced in the generic patch of that series. > > I really don't like to see patches get a wholesale replacement, especially > when they've been looked at by a few people and have had some testing, etc. > It's not possible to see what changed and people need to re-review stuff > they've already reviewed, etc.
Sorry, I didn't know that this is the preferred way. I just thought it's more clear if the patches are replaced if the patch set is finally pushed into Linus' tree.
> diff -puN arch/powerpc/kernel/machine_kexec.c~use-extended-crashkernel-command-line-on-ppc64-update arch/powerpc/kernel/machine_kexec.c > --- a/arch/powerpc/kernel/machine_kexec.c~use-extended-crashkernel-command-line-on-ppc64-update > +++ a/arch/powerpc/kernel/machine_kexec.c > @@ -63,7 +63,7 @@ NORET_TYPE void machine_kexec(struct kim > > void __init reserve_crashkernel(void) > { > - unsigned long long crash_size = 0, crash_base; > + unsigned long long crash_size, crash_base; > int ret; > > /* this is necessary because of lmb_phys_mem_size() */ > _ > > > which I suspect will now create a compiler warning.
No, it doesn't. I just verified this.
CHK include/linux/compile.h CC arch/powerpc/kernel/machine_kexec.o LD arch/powerpc/kernel/built-in.o
Thanks, Bernhard -- Bernhard Walle <bwalle@suse.de>, Architecture Maintenance SUSE LINUX Products GmbH, Nürnberg, Germany GF: Markus Rex, HRB 16746 (AG Nürnberg) OpenPGP: F61F 34CC 09CA FB82 C9F6 BA4B 8865 3696 DDAF 6454 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |