Messages in this thread Patch in this message | | | Subject | [patch] fix sys_mknodat breakage from r/o bind mounts | From | Miklos Szeredi <> | Date | Wed, 26 Sep 2007 00:58:47 +0200 |
| |
From: Miklos Szeredi <mszeredi@suse.cz>
mknod("foo", 0644) returns EINVAL, even though it should succeed.
The responsible patch is this:
r-o-bind-mounts-sys_mknodat-elevate-write-count-for-vfs_mknod-create.patch
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> ---
Index: linux/fs/namei.c =================================================================== --- linux.orig/fs/namei.c 2007-09-26 00:36:15.000000000 +0200 +++ linux/fs/namei.c 2007-09-26 00:51:19.000000000 +0200 @@ -1984,7 +1984,7 @@ asmlinkage long sys_mknodat(int dfd, con goto out_dput; } if (!S_ISREG(mode) && !S_ISCHR(mode) && !S_ISBLK(mode) && - !S_ISFIFO(mode) && !S_ISSOCK(mode) && mode != 0) { + !S_ISFIFO(mode) && !S_ISSOCK(mode) && (mode & S_IFMT) != 0) { error = -EINVAL; goto out_dput; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |