lkml.org 
[lkml]   [2007]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[36/50] Fix device address listing for ipv4.

    From: Stephen Hemminger <shemminger@linux-foundation.org>

    commit 596e41509550447b030f7b16adaeb0138ab585a8 in mainline

    Bug: http://bugzilla.kernel.org/show_bug.cgi?id=8876

    Not all ips are shown by "ip addr show" command when IPs number assigned to an
    interface is more than 60-80 (in fact it depends on broadcast/label etc
    presence on each address).

    Steps to reproduce:
    It's terribly simple to reproduce:

    # for i in $(seq 1 100); do ip ad add 10.0.$i.1/24 dev eth10 ; done
    # ip addr show

    this will _not_ show all IPs.
    Looks like the problem is in netlink/ipv4 message processing.

    This is fix from bug submitter, it looks correct.

    Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    net/ipv4/devinet.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/ipv4/devinet.c
    +++ b/net/ipv4/devinet.c
    @@ -1194,7 +1194,7 @@ static int inet_dump_ifaddr(struct sk_bu
    for (ifa = in_dev->ifa_list, ip_idx = 0; ifa;
    ifa = ifa->ifa_next, ip_idx++) {
    if (ip_idx < s_ip_idx)
    - goto cont;
    + continue;
    if (inet_fill_ifaddr(skb, ifa, NETLINK_CB(cb->skb).pid,
    cb->nlh->nlmsg_seq,
    RTM_NEWADDR, NLM_F_MULTI) <= 0)
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-24 18:43    [W:0.024 / U:98.068 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site