Messages in this thread |  | | Subject | Re: [RFC] New kernel-message logging API | From | Joe Perches <> | Date | Sun, 23 Sep 2007 12:25:15 -0700 |
| |
On Sun, 2007-09-23 at 10:39 +0200, Vegard Nossum wrote: > On 9/23/07, Joe Perches <joe@perches.com> wrote: > > Given the number of 80 column zealots, character naming length > > matters. > I don't know. Compare the following two lines: > printk(KERN_INFO "Message.\n"); > kprint_info("Message.");
The problem isn't printk(KERN_<level> to kprint_<level>(.
The problems are the no level printk(foo)s to kprint_<level>(foo) and the pr_<level>() to kprint_<level>() translations.
> By dropping the lengthy macro (it's not like it's going to change > while we're running anyway, so why not make it a part of the function > name?) and the final newline, we actually end up with a net decrease > in line length.
Which I do appreciate and think good.
> I thought it would be nice to have something that looks familiar, > since that would ease an eventual transition. klog is a valid > alternative, but isn't kp a bit cryptic?
Probably no more than pr_<level> is today.
cheers, Joe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |