lkml.org 
[lkml]   [2007]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] cxacru: Reduce initialisation delay
On 23/09/07 17:23, Duncan Sands wrote:
> Hi Simon,
>
>> + usb_info(usbatm, "started firmware\n");
> ...
>> + usb_info(usbatm, "loaded config data\n");
>
> maybe these should be debug messages. When are they useful?

They are probably only useful as debug messages - although it
may be desirable to know when the configuration has been set.



Also... it doesn't make sense to load the configuration only
in heavy_init - if the configuration is changed then there's
no way in the module to resend it without powering the device
down and up. Some sysfs parameters to change configuration
could be useful... except there's no information as to what
these settings are.

--
Simon Arlott
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-09-23 20:35    [W:0.037 / U:2.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site