[lkml]   [2007]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: memset as memzero
    On Sat, Sep 22, 2007 at 11:53:53AM -0700, Linus Torvalds wrote:
    > On Sat, 22 Sep 2007, Arjan van de Ven wrote:
    > >
    > > it doesn't add value.... memset with a constant 0 is just as fast
    > > (since the compiler knows it's 0) than any wrapper around it, and the
    > > syntax around it is otherwise the same.
    > Indeed.
    > The reason we have "clear_page()" is not because the value we're writing
    > is constant - that doesn't really help/change anything at all. We could
    > have had a "fill_page()" that sets the value to any random byte, it's just
    > that zero is the only value that we really care about.
    > So the reason we have "clear_page()" is because the *size* and *alignment*
    > is constant and known at compile time, and unlike the value you write,
    > that actually matters.
    > So "memzero()" would never really make sense as anything but a syntactic
    > wrapper around "memset(x,0,size)".

    There is one useful argument for memzero (or bzero to give it its proper
    name), and that's that it's impossible to screw up.
    I'm still amazed at how many times I see

    memset (x,size,0);

    in various code. So much so, that my editor highlights it now to spot
    it during code review. As does my mail client. To be on the safe
    side, I also have a cron job grepping for it in my ~/Mail/commits
    for all the projects I'm interested in.

    It's tragic really just how easy it is to screw it up.


    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-09-23 17:37    [W:0.022 / U:0.248 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site