Messages in this thread | | | Date | Sat, 22 Sep 2007 11:13:03 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2] pcmcia: Convert io_req_t to use kio_addr_t |
| |
On Sat, Sep 22, 2007 at 12:25:51AM -0600, Matthew Wilcox wrote: > > What about the formatting and field widths ? > > > > ulong would probably be a lot saner than kio_addr_t and yet more type > > obfuscation. > > I don't think anyone uses ioports > 32bit. Certainly i386 takes an int > port as parameter to {in,out}[bwl] (and it really only uses 16-bits). > parisc uses 24 bits. I don't know what the various ppcs do, but pci > bars can only be 32-bit for ioports. So my opinion is that ioports > should be uint, not ulong.
The kernel seems to mostly use int, sometimes uint. I never quite got why pcmcia had to have it's own strange typedef for them.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |