Messages in this thread Patch in this message | | | Date | Sat, 22 Sep 2007 01:41:17 -0700 (PDT) | From | Matti Linnanvuori <> | Subject | [PATCH] include/linux/mutex.h: unclear reference to convention |
| |
From: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
Reference to two different conventions is unnecessarily unclear unless you know them already and requires seeking and reading another file for understanding.
Signed-off-by: Matti Linnanvuori <mattilinnanvuori@yahoo.com> ---
--- linux-2.6.23-rc7/include/linux/mutex.h 2007-09-22 11:09:42.223763000 +0300 +++ linux-2.6.23/include/linux/mutex.h 2007-09-22 11:11:19.416761000 +0300 @@ -132,9 +132,19 @@ extern int __must_check mutex_lock_inter # define mutex_lock_interruptible_nested(lock, subclass) mutex_lock_interruptible(lock) #endif -/* - * NOTE: mutex_trylock() follows the spin_trylock() convention, - * not the down_trylock() convention! +/*** + * mutex_trylock - try acquire the mutex, without waiting + * @lock: the mutex to be acquired + * + * Try to acquire the mutex atomically. Returns 1 if the mutex + * has been acquired successfully, and 0 on contention. + * + * NOTE: this function follows the spin_trylock() convention, so + * it is negated to the down_trylock() return values! Be careful + * about this when converting semaphore users to mutexes. + * + * This function must not be used in interrupt context. The + * mutex must be released by the same task that acquired it. */ extern int fastcall mutex_trylock(struct mutex *lock); extern void fastcall mutex_unlock(struct mutex *lock);
________ Yahoo! Clever: Stellen Sie Fragen und finden Sie Antworten. Teilen Sie Ihr Wissen. www.yahoo.de/clever - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |