lkml.org 
[lkml]   [2007]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 18/25] elevate writer count for do_sys_truncate()
    From
    Date


    Acked-by: Christoph Hellwig <hch@infradead.org>
    Signed-off-by: Dave Hansen <haveblue@us.ibm.com>
    ---

    lxc-dave/fs/open.c | 14 ++++++++------
    1 file changed, 8 insertions(+), 6 deletions(-)

    diff -puN fs/open.c~elevate-writer-count-for-do-sys-truncate fs/open.c
    --- lxc/fs/open.c~elevate-writer-count-for-do-sys-truncate 2007-09-20 12:16:19.000000000 -0700
    +++ lxc-dave/fs/open.c 2007-09-20 12:16:19.000000000 -0700
    @@ -244,21 +244,21 @@ static long do_sys_truncate(const char _
    if (!S_ISREG(inode->i_mode))
    goto dput_and_out;

    - error = vfs_permission(&nd, MAY_WRITE);
    + error = mnt_want_write(nd.mnt);
    if (error)
    goto dput_and_out;

    - error = -EROFS;
    - if (IS_RDONLY(inode))
    - goto dput_and_out;
    + error = vfs_permission(&nd, MAY_WRITE);
    + if (error)
    + goto mnt_drop_write_and_out;

    error = -EPERM;
    if (IS_IMMUTABLE(inode) || IS_APPEND(inode))
    - goto dput_and_out;
    + goto mnt_drop_write_and_out;

    error = get_write_access(inode);
    if (error)
    - goto dput_and_out;
    + goto mnt_drop_write_and_out;

    /*
    * Make sure that there are no leases. get_write_access() protects
    @@ -276,6 +276,8 @@ static long do_sys_truncate(const char _

    put_write_and_out:
    put_write_access(inode);
    +mnt_drop_write_and_out:
    + mnt_drop_write(nd.mnt);
    dput_and_out:
    path_release(&nd);
    out:
    _
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-09-20 22:01    [W:0.022 / U:0.476 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site