lkml.org 
[lkml]   [2007]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 02/24] rearrange may_open() to be r/o friendly
From
Date
On Wed, 2007-09-19 at 18:27 +0100, Christoph Hellwig wrote:
> > int permission(struct inode *inode, int mask, struct nameidata *nd)
> > {
> > int retval, submask;
> > + struct vfsmount *mnt = NULL;
> > +
> > + if (nd)
> > + mnt = nd->mnt;
> >
> > if (mask & MAY_WRITE) {
> > umode_t mode = inode->i_mode;
> > @@ -251,7 +255,7 @@ int permission(struct inode *inode, int
> > * MAY_EXEC on regular files is denied if the fs is mounted
> > * with the "noexec" flag.
> > */
> > - if (nd && nd->mnt && (nd->mnt->mnt_flags & MNT_NOEXEC))
> > + if (mnt && (mnt->mnt_flags & MNT_NOEXEC))
>
> Why is this entirely unrelated cleanup in this patch?
>
> Except for that it looks fine.

You're right. In this context, it looks completely unrelated. I'll
separate it into another patch.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-09-20 20:51    [W:0.135 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site