lkml.org 
[lkml]   [2007]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/4] [-mm patch] Rename macros returning the size.
On Thu, 20 Sep 2007, Satyam Sharma wrote:

> > [PATCH 5/4] [-mm patch] Rename macros returning the size.
> > The #define SIZE() should be renamed STRUCT_SIZE() since it's always
> > returning the size of the struct with a given name. This would allow
> > TYPEDEF_SIZE() to simply become SIZE() since it need not be used
> > exclusively for typedefs. This idea is David Rientjes's.
> > http://www.ussg.iu.edu/hypermail/linux/kernel/0709.1/1964.html
> >
> > Thanks
> > Ken'ichi Ohmichi
> >
> > ---
> > Signed-off-by: David Rientjes <rientjes@google.com>
>
> Hmm, I think adding a s-o-b line for David here isn't quite correct.
> When someone reviews a patch and gives a suggestion, you only need to
> copy him on the next iteration (and he may ack it or whatever, if he
> wants) -- but adding a s-o-b line like that ends up (incorrectly)
> denoting that he came between the author-to-git-commit chain ...
>

Feel free to add

Acked-by: David Rientjes <rientjes@google.com>

since I've reviewed the patch and agree with it.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-09-20 20:45    [W:0.055 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site