lkml.org 
[lkml]   [2007]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Clarify pci_iomap() usage for MMIO-only devices


    On Tue, 18 Sep 2007, Luis R. Rodriguez wrote:
    >
    > Alright, here is the same patch inline with s/recommended/required/ language:

    Well, the thing is, I'm not at all sure that I agree with this.

    If you use ioport_map/unmap, then you really *should* access them with the
    proper iomem accessors (ioread/iowrite). The fact that it may happen to
    work (when using the default lib/iomap.c implementation, at least) on
    some architectures and with the current implementation still doesn't mean
    that you should necessarily use readb/writeb.

    After all, you cannot use "inb/outb" on it, even if would happen to be an
    IO address.

    So what is this usage that wants to use the bogus accessor? Why not fix
    that instead of adding documentation for something that is very arguably
    something we want to *avoid* having people do!

    Linus
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-18 21:07    [W:4.013 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site