Messages in this thread | | | From | Denys Vlasenko <> | Subject | bnx2 dirver's firmware images | Date | Tue, 18 Sep 2007 18:23:26 +0100 |
| |
Hi Michael,
In bnx2_fw.h I see the following:
static u32 bnx2_RXP_b06FwBss[(0x13dc/4) + 1] = { 0x0 };
static struct fw_info bnx2_rxp_fw_06 = { ... .bss = bnx2_RXP_b06FwBss, ... };
I grepped for the usage of .bss member (grepped for '[.>]bss[^_]') and it is used only here:
if (fw->bss) { int j;
for (j = 0; j < (fw->bss_len/4); j++, offset += 4) { REG_WR_IND(bp, offset, fw->bss[j]); } }
If I understand it correctly, you read zero words one by one from bnx2_RXP_b06FwBss and writing them into the card. This is very suboptimal usage of nearly 5k of kernel unswappable memory.
Do you plan to fix it?
Do you have any plans to switch to request_firmware() interface, which will allow you to avoid keeping firmware in unswappable kernel memory and thus free ~80k?
$ size bnx2.o text data bss dec hex filename 52255 81551 6360 140166 22386 bnx2.o -- vda - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |