lkml.org 
[lkml]   [2007]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 102/104] KVM: x86 emulator: fix src, dst value initialization
    Date
    From: Nitin A Kamble <nitin.a.kamble@intel.com>

    Some operand fetches are less than the machine word size and can result in
    stale bits if used together with operands of different sizes.

    Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
    Signed-off-by: Avi Kivity <avi@qumranet.com>
    ---
    drivers/kvm/x86_emulate.c | 2 ++
    1 files changed, 2 insertions(+), 0 deletions(-)

    diff --git a/drivers/kvm/x86_emulate.c b/drivers/kvm/x86_emulate.c
    index cf8db67..7360a71 100644
    --- a/drivers/kvm/x86_emulate.c
    +++ b/drivers/kvm/x86_emulate.c
    @@ -827,6 +827,7 @@ done_prefixes:
    srcmem_common:
    src.type = OP_MEM;
    src.ptr = (unsigned long *)cr2;
    + src.val = 0;
    if ((rc = ops->read_emulated((unsigned long)src.ptr,
    &src.val, src.bytes, ctxt->vcpu)) != 0)
    goto done;
    @@ -891,6 +892,7 @@ done_prefixes:
    dst.type = OP_MEM;
    dst.ptr = (unsigned long *)cr2;
    dst.bytes = (d & ByteOp) ? 1 : op_bytes;
    + dst.val = 0;
    if (d & BitOp) {
    unsigned long mask = ~(dst.bytes * 8 - 1);

    --
    1.5.3
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-17 10:57    [W:0.020 / U:0.264 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site