Messages in this thread | | | Date | Mon, 17 Sep 2007 19:20:44 -0700 (PDT) | Subject | Re: [PATCH] 2.6.22.6 NETWORKING [IPV4]: Always use source addr in skb to reply packet | From | David Miller <> |
| |
From: lepton <ytht.net@gmail.com> Date: Tue, 18 Sep 2007 10:16:17 +0800
> Hi, > In some situation, icmp_reply and ip_send_reply will send > out packet with the wrong source addr, the following patch > will fix this. > > I don't understand why we must use rt->rt_src in the current > code, if this is a wrong fix, please correct me. > > Signed-off-by: Lepton Wu <ytht.net@gmail.com>
That the address is wrong is your opinion only :-)
Source address selection is a rather complex topic, and here we are definitely purposefully using the source address selected by the routing lookup for the reply. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |