Messages in this thread | | | Date | Mon, 17 Sep 2007 20:17:07 +0400 | From | Evgeniy Polyakov <> | Subject | Re: [ofa-general] Re: [PATCH v2] iw_cxgb3: Support "iwarp-only" interfaces to avoid 4-tuple conflicts. |
| |
On Mon, Sep 17, 2007 at 09:09:06AM -0700, Sean Hefty (mshefty@ichips.intel.com) wrote: > >>>+ addr = kmalloc(sizeof *addr, GFP_KERNEL); > >> > >>As a small nitpick: this wants to be sizeof(struct in_ifaddr) > > See chapter 14 of CodingStyle document. kmalloc(sizeof *addr... is correct.
Come on, do not start a flame war about how parameters into kmalloc should be provided - there are much more serious issues unresolved yes. It does help grepping the code, but if you feel that this is a serious threat, then use your preferred way.
-- Evgeniy Polyakov - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |