lkml.org 
[lkml]   [2007]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 001/104] KVM: Fix *nopage() in kvm_main.c
    Date
    On Monday 17 September 2007 19:18, Avi Kivity wrote:
    > Avi Kivity wrote:
    > > Christoph Hellwig wrote:
    > >> On Mon, Sep 17, 2007 at 10:30:43AM +0200, Avi Kivity wrote:
    > >>> From: Nguyen Anh Quynh <aquynh@gmail.com>
    > >>>
    > >>> *nopage() in kvm_main.c should only store the type of mmap() fault if
    > >>> the pointers are not NULL. This patch fixes the problem.
    > >>
    > >> Care to convert it to ->faul while you're at it?
    > >
    > > I'll add this to my todo, though not sure It'll be in time for .24. If
    > > someone sends a patch I'll apply it.
    >
    > I should mention that the converting to use ->fault() is a 15-minute
    > change; the tricky part is adding backwards compatibility for the
    > external module package.

    It should be mostly possible to ifdef a nopage() handler, which is
    just a wrapper function to translate arguments then call your new
    ->fault() handler. With luck, fault would mostly inline into nopage,
    and do some constant folding to make it cheaper...

    I'm planning to go through and convert the rest of the in-tree users
    at some point soon, so if you do get a chance to convert your
    upstream code before I try, it would nice ;)

    Thanks,
    Nick
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-17 15:45    [W:4.418 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site