lkml.org 
[lkml]   [2007]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: [PATCH 2/3] Consolidate host virtualization support under Virtualization menu
    From
    Date
    On Fri, 2007-09-14 at 09:19 -0700, Randy Dunlap wrote:
    > On Fri, 14 Sep 2007 15:18:44 +1000 Rusty Russell wrote:
    >
    > > We turn "Virtualization" into a menu, not a config option, since it's
    > > actually only used as a menu. Then we move lguest under that menu.
    >
    > so you want to revert the 2007-july-16 merge that changes
    > menu -> menuconfig and makes most of the menus consistent in
    > presentation. I'd rather not, but I don't own it.

    Ok, I missed that one. To me it seems gratuitous to create a config
    option simply to control a menu. However if that is considered the
    Right Way, here is the "Just move lguest" variant.

    > And Yes, lguest does need to be moved into a better location.

    Indeed,
    Rusty.
    ===
    Move lguest under the virtualization menu.

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

    diff -r c2893801de2a drivers/Kconfig
    --- a/drivers/Kconfig Fri Sep 14 13:24:46 2007 +1000
    +++ b/drivers/Kconfig Fri Sep 14 13:24:49 2007 +1000
    @@ -87,6 +87,4 @@ source "drivers/kvm/Kconfig"
    source "drivers/kvm/Kconfig"

    source "drivers/uio/Kconfig"
    -
    -source "drivers/lguest/Kconfig"
    endmenu
    diff -r c2893801de2a drivers/kvm/Kconfig
    --- a/drivers/kvm/Kconfig Fri Sep 14 13:24:46 2007 +1000
    +++ b/drivers/kvm/Kconfig Fri Sep 14 13:32:22 2007 +1000
    @@ -45,4 +36,8 @@ config KVM_AMD
    Provides support for KVM on AMD processors equipped with the AMD-V
    (SVM) extensions.

    -endif # VIRTUALIZATION
    +# OK, it's a little counter-intuitive to do this, but it puts it neatly under
    +# the virtualization menu.
    +source drivers/lguest/Kconfig
    +
    +endif # VIRTUALIZATION


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-15 05:09    [W:0.030 / U:28.464 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site