lkml.org 
[lkml]   [2007]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] add consts where appropriate in sound/pci/hda/*
Date
On Friday 14 September 2007 18:48, Denys Vlasenko wrote:
> There is a lot of data structures in that code,
> and most of them seems to be read-only.
>
> I added const modifiers to most of such places:
>
> text data bss dec hex filename
> 106315 179564 36 285915 45cdb snd-hda-intel.o
> 283051 2624 36 285711 45c0f snd-hda-intel_patched.o
>
> Patch is attached.
>
> It moves "static struct hda_codec_preset *hda_preset_tables[]"
> from hda_patch.h to hda_codec.c, and then adds
> #include "hda_patch.h"
> in a few .c files so that definitions of e.g.
> const struct hda_codec_preset snd_hda_preset_analog[]
> are checked to match declarations in hda_patch.h
>
> The rest of the patch (bulk of it) adds "const"
> in many places.
>
> Patch is compile tested. Please apply.

After additional testing I found a place where
I forgot to add 'const', and build throws warnings
at me.

Updated patch is attached.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
--
vda
[unhandled content-type:application/x-bzip2]
\
 
 \ /
  Last update: 2007-09-15 00:15    [W:0.518 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site