Messages in this thread | | | Date | Wed, 12 Sep 2007 16:08:27 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] pci: fix unterminated pci_device_id lists |
| |
On Wed, 12 Sep 2007 14:53:56 -0700 Greg KH <greg@kroah.com> wrote:
> On Wed, Sep 12, 2007 at 03:48:49PM +0400, Alexey Dobriyan wrote: > > On 9/12/07, Jeff Garzik <jeff@garzik.org> wrote: > > > Kees Cook wrote: > > > > This patch against 2.6.23-rc6 fixes a couple drivers that do not > > > > correctly terminate their pci_device_id lists. This results in garbage > > > > being spewed into modules.pcimap when the module happens to not have > > > > 28 NULL bytes following the table, and/or the last PCI ID is actually > > > > truncated from the table when calculating the modules.alias PCI aliases, > > > > cause those unfortunate device IDs to not auto-load. > > > > > > > > Signed-off-by: Kees Cook <kees@ubuntu.com> > > > > > > ACK > > > > I mut say, non-terminated PCI ids lists are constant PITA. There should be > > a way to a) put it in macro[1], so that terminator automatically added, and > > b) still allow #ifdef inside table like, e.g. 8139too does. > > > > [1] or not macro, because #ifdef inside macros aren't allowed. > > If you know of a way to do this in an easier manner, patches are always > gladly accepted :)
Change (ie: fix) the APIs to take a `length' arg, then fix up 10^42 drivers.
Oh, you said "easy" ;)
Perhaps there's some clever way in which we can check that the tables are correctly terminated. I guess some static code-checker could do it. A weaker option would be to do some runtime hack which carefully walks the table and checks stuff.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |