lkml.org 
[lkml]   [2007]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/12] IB/ehca: Replace get_paca()->paca_index by the more portable raw_smp_processor_id()
    Date
    We can use raw_smp_processor_id() here because the processor ID is only used
    for debug output and may therefore be preemption-unsafe.

    Signed-off-by: Joachim Fenkes <fenkes@de.ibm.com>
    ---

    This is the same patch, but with smp_processor_id() replaced by
    raw_smp_processor_id(), as kindly pointed out to me by Nathan. Thanks!

    drivers/infiniband/hw/ehca/ehca_tools.h | 14 +++++++-------
    1 files changed, 7 insertions(+), 7 deletions(-)

    diff --git a/drivers/infiniband/hw/ehca/ehca_tools.h b/drivers/infiniband/hw/ehca/ehca_tools.h
    index f9b264b..4a8346a 100644
    --- a/drivers/infiniband/hw/ehca/ehca_tools.h
    +++ b/drivers/infiniband/hw/ehca/ehca_tools.h
    @@ -73,37 +73,37 @@ extern int ehca_debug_level;
    if (unlikely(ehca_debug_level)) \
    dev_printk(KERN_DEBUG, (ib_dev)->dma_device, \
    "PU%04x EHCA_DBG:%s " format "\n", \
    - get_paca()->paca_index, __FUNCTION__, \
    + raw_smp_processor_id(), __FUNCTION__, \
    ## arg); \
    } while (0)

    #define ehca_info(ib_dev, format, arg...) \
    dev_info((ib_dev)->dma_device, "PU%04x EHCA_INFO:%s " format "\n", \
    - get_paca()->paca_index, __FUNCTION__, ## arg)
    + raw_smp_processor_id(), __FUNCTION__, ## arg)

    #define ehca_warn(ib_dev, format, arg...) \
    dev_warn((ib_dev)->dma_device, "PU%04x EHCA_WARN:%s " format "\n", \
    - get_paca()->paca_index, __FUNCTION__, ## arg)
    + raw_smp_processor_id(), __FUNCTION__, ## arg)

    #define ehca_err(ib_dev, format, arg...) \
    dev_err((ib_dev)->dma_device, "PU%04x EHCA_ERR:%s " format "\n", \
    - get_paca()->paca_index, __FUNCTION__, ## arg)
    + raw_smp_processor_id(), __FUNCTION__, ## arg)

    /* use this one only if no ib_dev available */
    #define ehca_gen_dbg(format, arg...) \
    do { \
    if (unlikely(ehca_debug_level)) \
    printk(KERN_DEBUG "PU%04x EHCA_DBG:%s " format "\n", \
    - get_paca()->paca_index, __FUNCTION__, ## arg); \
    + raw_smp_processor_id(), __FUNCTION__, ## arg); \
    } while (0)

    #define ehca_gen_warn(format, arg...) \
    printk(KERN_INFO "PU%04x EHCA_WARN:%s " format "\n", \
    - get_paca()->paca_index, __FUNCTION__, ## arg)
    + raw_smp_processor_id(), __FUNCTION__, ## arg)

    #define ehca_gen_err(format, arg...) \
    printk(KERN_ERR "PU%04x EHCA_ERR:%s " format "\n", \
    - get_paca()->paca_index, __FUNCTION__, ## arg)
    + raw_smp_processor_id(), __FUNCTION__, ## arg)

    /**
    * ehca_dmp - printk a memory block, whose length is n*8 bytes.
    --
    1.5.2




    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-12 16:47    [W:2.538 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site