Messages in this thread | | | From | Michael Neuling <> | Subject | Re: [PATCH] powerpc: add new required termio functions | Date | Wed, 12 Sep 2007 12:34:08 +1000 |
| |
> On Wed, 12 Sep 2007, Michael Neuling wrote: > > > > The "tty: termios locking functions break with new termios type" patch > > (f629307c857c030d5a3dd777fee37c8bb395e171) breaks the powerpc compile. > > Really? > > It shouldn't. The use of kernel_termios_to_user_termios_1() is conditional > on the architecture having a define for TCGETS2, and I think they match > up. I see: > > [torvalds@woody linux]$ git grep -l kernel_termios_to_user_termios_1 in clude | wc -l > 10 > [torvalds@woody linux]$ git grep -l TCGETS2 include | wc -l > 10 > > and in neither case is ppc in that list of architecures. > > So maybe you just read the patch without actually testing whether it > actually broke powerpc?
Not, I actually compiled it.
> Or is something subtler going on?
Looks like those new calls are not protected by the TCGETS2 define. Adding those ifdefs seems like the correct fix.
Mikey
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |