lkml.org 
[lkml]   [2007]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] drivers/firmware: const-ify DMI API and internals
    Date
    On Saturday 01 September 2007, Jeff Garzik wrote:
    >
    > commit 457b6eb3bf3341d2e143518a0bb99ffbb8d754c4
    > Author: Jeff Garzik <jeff@garzik.org>
    > Date: Sat Sep 1 10:16:45 2007 -0400
    >
    > drivers/firmware: const-ify DMI API and internals
    >
    > Three main sets of changes:
    >
    > 1) dmi_get_system_info() return value should have been marked const,
    > since callers should not be changing that data.
    >
    > 2) const-ify DMI internals, since DMI firmware tables should,
    > whenever possible, be marked const to ensure we never ever write to
    > that data area.
    >
    > 3) const-ify DMI API, to enable marking tables const where possible
    > in low-level drivers.
    >
    > And if we're really lucky, this might enable some additional
    > optimizations on the part of the compiler.
    >
    > The bulk of the changes are #2 and #3, which are interrelated. #1 could
    > have been a separate patch, but it was so small compared to the others,
    > it was easier to roll it into this changeset.
    >
    > Signed-off-by: Jeff Garzik <jeff@garzik.org>

    [ a bit late ]

    Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-11 23:57    [W:0.023 / U:30.896 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site