Messages in this thread | | | Date | Tue, 11 Sep 2007 23:51:40 +0200 | From | Adrian Bunk <> | Subject | Re: x86 merge - a little feedback |
| |
On Tue, Sep 11, 2007 at 10:34:23PM +0100, Andi Kleen wrote: > > > > > People do not expect code under arch/i386/ to be used by code under > > arch/x86_64/ and vice versa. > > > > That regularly results in people sending patches that don't compile on > > the other architecture. > > > > With one architecture it's much more obvious that the code is shared. > > Will that cause people to compile test both? I have my doubts that > will really work. >...
You will see that it could be shared, and it'll be much easier to see all configurations it's used in.
Currently, there are 6 or 7 different ways how a function under arch/i386/ could be used by a function under arch/x86_64/ (and vice versa) and it's non-trivial to figure out all usages when grep'ing for users.
> -Andi
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |