Messages in this thread | | | Date | Tue, 11 Sep 2007 14:24:05 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: x86 merge - a little feedback |
| |
On Tue, 11 Sep 2007, Thomas Gleixner wrote: > > I tried to unify the Makefile by using > > obj-$(CONFIG_X86_32) += .... > and > obj-$(CONFIG_X86_64) += ....
Don't do that.
I think it would be much better to instead do something like
obj-y += mmconfig_$(CONFIG_WORD_SIZE).o
to make it clear when we have a file that is conceptually the same, but has different implementations.
That also makes the unification (assuming/hoping it gets done) of such files much cleaner - you just merge them, and the obj-y line can just drop the $(CONFIG_WORD_SIZE) thing. Very logical.
> but I did fail due to link order problems in that code.
.. the above approach also gets rid of any link order problems.
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |