lkml.org 
[lkml]   [2007]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors.
Date
From
> 
> If this is experimental, perhaps you should mark the depends line as
> such
> depends on on DMA_ENGINE && PPC && EXPERIMENTAL

I'll add EXPERIMENTAL for MPC83xx only.

>
> [...]
>
> >+
> >+ fsl_dma_memcpy_issue_pending(chan);
> >+ while (fsl_dma_is_complete(chan, cookie, NULL, NULL)
> >+ != DMA_SUCCESS);
>
> Again, is it possible to hang your thread here?
>
> [...]

I'll add msleep here.

Thanks!

- zw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-09-11 12:13    [from the cache]
©2003-2011 Jasper Spaans