lkml.org 
[lkml]   [2007]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/25] [PATCH] Add debugreg/load_rsp native hooks
Andi Kleen wrote:
>> @@ -264,13 +270,64 @@ struct thread_struct {
>> set_fs(USER_DS); \
>> } while(0)
>>
>> -#define get_debugreg(var, register) \
>> - __asm__("movq %%db" #register ", %0" \
>> - :"=r" (var))
>> -#define set_debugreg(value, register) \
>> - __asm__("movq %0,%%db" #register \
>> - : /* no output */ \
>> - :"r" (value))
>> +static inline unsigned long native_get_debugreg(int regno)
>> +{
>> + unsigned long val;
>>
>
> It would be better to have own functions for each debug register I think
>

? A separate pvop for each? Seems excessive. And surely this should
be identical to 32bit either way.

J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-08-09 07:51    [W:0.227 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site