Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures | Date | Thu, 9 Aug 2007 14:41:25 +0200 |
| |
On Thursday 09 August 2007, Chris Snook wrote: > This patchset makes the behavior of atomic_read uniform by removing the > volatile keyword from all atomic_t and atomic64_t definitions that currently > have it, and instead explicitly casts the variable as volatile in > atomic_read(). This leaves little room for creative optimization by the > compiler, and is in keeping with the principles behind "volatile considered > harmful". >
Just an idea: since all architectures already include asm-generic/atomic.h, why not move the definitions of atomic_t and atomic64_t, as well as anything that does not involve architecture specific inline assembly into the generic header?
Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |