lkml.org 
[lkml]   [2007]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 06/25] sysfs: Simplify readdir.
    On Tue, Aug 07, 2007 at 03:13:14PM -0600, Eric W. Biederman wrote:
    >
    > At some point someone wrote sysfs_readdir to insert a cursor
    > into the list of sysfs_dirents to ensure that sysfs_readdir would
    > restart properly. That works but it is complex code and tends
    > to be expensive.
    >
    > The same effect can be achieved by keeping the sysfs_dirents in
    > inode order and using the inode number as the f_pos. Then
    > when we restart we just have to find the first dirent whose inode
    > number is equal or greater then the last sysfs_dirent we attempted
    > to return.
    >
    > Removing the sysfs directory cursor also allows the remove of
    > all of the mysterious checks for sysfs_type(sd) != 0. Which
    > were nonbovious checks to see if a cursor was in a directory list.
    >
    > Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>

    Acked-by: Tejun Heo <htejun@gmail.com>

    --
    tejun
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-08 09:21    [W:0.022 / U:31.700 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site