lkml.org 
[lkml]   [2007]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/25] Sysfs cleanups & tagged directory support
    Tejun Heo wrote:
    > Eric W. Biederman wrote:
    >> Tejun Heo <htejun@gmail.com> writes:
    >>
    >>> Cornelia Huck wrote:
    >>>> On Wed, 08 Aug 2007 23:35:36 +0900,
    >>>> Tejun Heo <htejun@gmail.com> wrote:
    >>>>
    >>>>> Does the attached patch happen to fix the problem?
    >>>> Indeed it does; thanks!
    >>> Yeah, you seem to have 32bit off_t. UINT_MAX overflows, so...
    >> Weird. And we have it opening the directory O_LARGEFILE.
    >>
    >> I have no problems with the fix though.
    >
    > It's probably because of struct dirent definition used by readdir().

    More specifically, d_off field. It's a bit twisted. For the last
    entry, filp->f_pos gets written into the field and gets wrapped while
    being copied out to userland or in glibc.

    --
    tejun
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-08 17:19    [W:4.190 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site