lkml.org 
[lkml]   [2007]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 23/25] [PATCH] paravirt hooks for arch initialization
    On 8/8/07, Andi Kleen <ak@suse.de> wrote:
    >
    > > -static void discover_ebda(void)
    > > +void native_ebda_info(unsigned *addr, unsigned *size)
    >
    > I guess it would be better to use the resources frame work here.
    > Before checking EBDA check if it is already reserved. Then lguest/Xen
    > can reserve these areas and stop using it.
    Let's make sure I understand: So you suggest skipping discover
    altogether in case it is already reserved?

    >
    > > +/* Overridden in paravirt.c if CONFIG_PARAVIRT */
    > > +void __attribute__((weak)) memory_setup(void)
    > > +{
    > > + return setup_memory_region();
    > > +}
    > > +
    > > +
    > > void __init setup_arch(char **cmdline_p)
    > > {
    > > printk(KERN_INFO "Command line: %s\n", boot_command_line);
    > > @@ -231,12 +255,19 @@ void __init setup_arch(char **cmdline_p)
    > > saved_video_mode = SAVED_VIDEO_MODE;
    > > bootloader_type = LOADER_TYPE;
    > >
    > > + /*
    > > + * By returning non-zero here, a paravirt impl can choose to
    > > + * skip the rest of the setup process
    > > + */
    > > + if (paravirt_arch_setup())
    > > + return;
    >
    > Sorry, but that's an extremly ugly and clumpsy interface and will lead
    > to extensive code duplication in hypervisors because so much code
    > is disabled.

    We can just wipe out the return value right now. Note that it was a
    choice, it would only lead to code duplication if the hypervisor
    wanted it. But yeah, I understand your concern. They may chose to
    return 1 here just to change some tiny thing in the bottom.

    I don't know exactly what other kinds of hooks we could put there.
    lguest surely didn't need any. Are you okay with just turning it into
    void by now ?

    --
    Glauber de Oliveira Costa.
    "Free as in Freedom"
    http://glommer.net

    "The less confident you are, the more serious you have to act."
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-08 16:13    [W:4.153 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site