lkml.org 
[lkml]   [2007]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] net/tulip/xircom_cb.c: remove superfulous priv assignment
    Date
    Hello,

    Unpatched version does sth like this:

    dev = alloc_etherdev(...
    private = netdev_priv(dev);
    ...
    dev->priv = private;

    which doesn't make much sense (does it?) because this is done in
    alloc_netdev() already.

    struct net_device *alloc_netdev(...
    {
    ...
    if (sizeof_priv)
    dev->priv = netdev_priv(dev);

    This patch removes superfluous code.

    Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>

    drivers/net/tulip/xircom_cb.c | 32853 -> 32831 (-22 bytes)
    drivers/net/tulip/xircom_cb.o | 123984 -> 123984 (0 bytes)

    drivers/net/tulip/xircom_cb.c | 1 -
    1 file changed, 1 deletion(-)

    --- linux-2.6.23-rc1-mm2-a/drivers/net/tulip/xircom_cb.c 2007-08-01 08:43:46.000000000 +0200
    +++ linux-2.6.23-rc1-mm2-b/drivers/net/tulip/xircom_cb.c 2007-08-08 11:06:22.000000000 +0200
    @@ -271,7 +271,6 @@ static int __devinit xircom_probe(struct
    dev->hard_start_xmit = &xircom_start_xmit;
    dev->stop = &xircom_close;
    dev->get_stats = &xircom_get_stats;
    - dev->priv = private;
    #ifdef CONFIG_NET_POLL_CONTROLLER
    dev->poll_controller = &xircom_poll_controller;
    #endif
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-08-08 13:23    [W:0.021 / U:31.920 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site