Messages in this thread | | | Subject | Re: [PATCH 2.6.22.y] ieee1394: revert "sbp2: enforce 32bit DMA mapping" | From | Benjamin Herrenschmidt <> | Date | Tue, 07 Aug 2007 07:43:17 +1000 |
| |
On Mon, 2007-08-06 at 13:58 +0200, Olaf Hering wrote: > On Sun, Aug 05, Stefan Richter wrote: > > > Benjamin Herrenschmidt wrote: > > >>> If setting 32-bit DMA mask fails on ppc64, that sounds like a problem > > >>> with the DMA implementation on that architecture. There are enough cards > > >>> out there that only support 32-bit DMA that this really needs to work.. > > >> Yes, could the PPC folks please have a look at it? Thanks. > > > > > > Smells like we may have a bug there. No worries though, all current PPC > > > machines have an iommu that will not give out addresses above 32 bits > > > anyway, but I'll double check what's up. > > > > > > Do you see something in dmesg when that happens ? > > > > There was nothing in Olaf's report, except for trouble in sbp2 _after_ > > the failure. http://lkml.org/lkml/2007/8/1/344 (I don't have a PMac.) > > sbp2util_remove_command_orb_pool() does not check for lu->hi being NULL. > > dev->dma_mask is NULL too, thats why dma_direct_dma_supported() returns > false, and dma_set_mask() will return -EIO.
Strange... PCI devices should never have a NULL dma mask. I wonder how we get there...
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |