Messages in this thread | | | Date | Mon, 06 Aug 2007 16:55:54 -0400 | From | Vlad Yasevich <> | Subject | Re: [PATCH] SCTP: IPv4 mapped addr not returned in SCTPv6 accept() |
| |
Dave Johnson wrote: > Vlad Yasevich writes: >> Ok. First, this is a different bug, so I would prefer a separate patch. >> Also, I see the problem and it's ugly, but this solution is not really correct, >> both conceptually and code wise. >> >> Conceptually, the v4 code should never worry about V4-mapped addresses and shouldn't >> muck with them. They are IPv6 addresses and there should be a clean separation. >> >> Code wise, the code in the __sctp_connect() is terrible. >> >> Does the attached patch work for you in this case. > > Sorry about the confusion before, your patch to __sctp_connect() > fixes calls to getpeername() after connect() just fine. > > I'll post a patch for the accept()/getpeername() case in a bit. > > Acked-by: Dave Johnson <djohnson@sw.starentnetworks.com> >
I had time to tinker and pushed both patches already. They were in the last pull that Dave Miller did. I also tested both patches locally to make sure that they worked as supposed to.
-vlad - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |