lkml.org 
[lkml]   [2007]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] fix crash in sbp2_remove_device() when dma_set_mask() fails
    Fix crash in sbp2_remove_device() when dma_set_mask() fails.

    Signed-off-by: Olaf Hering <olh@suse.de>

    ---
    drivers/ieee1394/sbp2.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    --- a/drivers/ieee1394/sbp2.c
    +++ b/drivers/ieee1394/sbp2.c
    @@ -929,13 +929,14 @@ static void sbp2_remove_device(struct sb
    if (!lu)
    return;

    - hi = lu->hi;
    -
    if (lu->shost) {
    scsi_remove_host(lu->shost);
    scsi_host_put(lu->shost);
    }
    flush_scheduled_work();
    + hi = lu->hi;
    + if (!hi)
    + return;
    sbp2util_remove_command_orb_pool(lu);

    list_del(&lu->lu_list);
    @@ -977,8 +978,7 @@ static void sbp2_remove_device(struct sb

    lu->ud->device.driver_data = NULL;

    - if (hi)
    - module_put(hi->host->driver->owner);
    + module_put(hi->host->driver->owner);

    kfree(lu);
    }
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-08-06 14:23    [W:7.059 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site