lkml.org 
[lkml]   [2007]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/23] per device dirty throttling -v8

* Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> > also add the CONFIG_DEFAULT_RELATIME kernel option, which makes
> > "norelatime" the default for all mounts without an extra kernel boot
> > option.
>
> Should be a mount option.

it is already a mount option too.

> > + relatime [FS] default to enabled relatime updates on all
> > + filesystems.
> > +
> > + relatime= [FS] default to enabled/disabled relatime updates on
> > + all filesystems.
> > +
>
> Double patch

no - it was not a double patch, i made all the common variants valid
boot options: "relatime", "relatime=0/1", "norelatime" and
"norelatime=0/1". Anyway, this is mooth, in the latest (v2) version
there's only a single boot parameter.

> > +config DEFAULT_RELATIME
> > + bool "Mount all filesystems with relatime by default"
> > + default y
>
> Changes behaviour so probably should default n. Better yet it should
> be the mount option so its flexible and strongly encouraged for
> vendors.

relatime is a mount option already. And distros can disable it if they
want. (they are conscious about their kernel config selections anyway.)

> > +0
> > +#endif
> > +;
>
> This ifdef mess would go away for a mount option

i fixed that in v2.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-08-05 21:35    [W:0.119 / U:8.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site