lkml.org 
[lkml]   [2007]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 5/5] Net: ath5k, kconfig changes
    From
    Date
    On Thu, 2007-08-30 at 08:36 -0400, John W. Linville wrote:
    > On Thu, Aug 30, 2007 at 04:38:09AM +0300, Nick Kossifidis wrote:
    > > 2007/8/28, Christoph Hellwig <hch@infradead.org>:
    >
    > > > Also this whole patch seems rather pointless. It saves only
    > > > very little and turns the driver into a complete ifdef maze.
    >
    > > Also most
    > > people will use 5212 code only, 5211 cards are on some old laptops and
    > > 5210, well i couldn't even find a 5210 for actual testing :P
    >
    > FWIW, I'd bet dollars to donuts that distros will enable them all
    > together.

    I would certainly _hope_ that distros enable everything -that is in the
    kernel- that they can get their hands on, otherwise when you stick a
    card in, it doesn't just work.

    Dan

    > Is saving code space the only reason to turn these off? How much
    > space do you save?
    >
    > Is there some way you can isolate and/or limit the number of ifdef
    > blocks further? If so, we might consider a version of this patch
    > that depends on EMBEDDED or somesuch...?
    >
    > John

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-31 14:09    [W:0.034 / U:309.416 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site