Messages in this thread | | | Date | Thu, 30 Aug 2007 14:09:39 +0400 | From | Oleg Nesterov <> | Subject | Re: [PATCH 2.6.21] Return available first timeslice to the creator, not parent |
| |
On 08/30, Peter Zijlstra wrote: > > On Thu, 2007-08-30 at 13:49 +0400, Oleg Nesterov wrote: > > > > sched_exit() was removed in 2.6.23-rc. > > > > If you are going to re-introduce this logic, please don't do sched_exit() > > from release_task(). It was done this way just because we can't access > > ->parent after release_task(). But release_task() is called either too > > early, or too late for timeslice accounting, depending on ->exit_signal == -1. > > > > I'd suggest to do this in do_exit(), before the last schedule(). Without > > write_unlock_irq() the code above needs a couple of rcu_read_lock()'s. > > > > I am not sure Ingo will like this change though... > > This is not intended as re-introduction of the feature, this stems from > fixing this issue in older (read distro) kernels.
Ah, good, sorry for noise then.
In that case I don't think it makes sense to move sched_exit() to do_exit(), of course. This doesn't look suitable for the -stable tree.
Oleg.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |