Messages in this thread | | | Date | Thu, 30 Aug 2007 14:51:44 -0700 (PDT) | From | Casey Schaufler <> | Subject | Re: [PATCH] Version2 Smack: Simplified Mandatory Access Control Kernel |
| |
--- Jan Engelhardt <jengelh@computergmbh.de> wrote:
> > On Aug 27 2007 23:59, Thomas Bleher wrote: > > >> + for (cp = data - 1; cp != NULL; cp = strchr(cp + 1, '\n')) { > >> + if (*++cp == '\0') > >> + break; > >> + if (sscanf(cp, "%14s %30s\n", name, target) != 2) { > >> + printk("%s:%d bad scan\n", > >> + __func__, __LINE__); > > > >Leftover debugging printk? Otherwise, a level would be nice. > > Or even pr_debug. > > (pr_debug("%s...
I'm taking out the printk.
> >> + static struct tree_descr smack_files[] = { > > Hey, can we make this const, if it does not change at runtime?
simple_fill_super() is unhappy with a const.
Casey Schaufler casey@schaufler-ca.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |