Messages in this thread | | | Date | Thu, 30 Aug 2007 12:30:57 -0400 | From | Chuck Ebbert <> | Subject | Re: 2.6.23-rc3-mm1 - vdso and gettimeofday issues with glibc |
| |
On 08/29/2007 07:15 PM, Andrew Morton wrote: > > So it's an interaction between the x86_64 vdso patches in Andi's tree and > newer glibc, and we don't know which one is getting it wrong yet? >
Just found this duplicated code in 2.6.23-rc4, maybe it was supposed to be something else? The second one was added in the x86_64 vdso patch.
arch/x86_64/kernel/vsyscall.c:
void update_vsyscall(struct timespec *wall_time, struct clocksource *clock) { unsigned long flags;
write_seqlock_irqsave(&vsyscall_gtod_data.lock, flags); /* copy vsyscall data */ vsyscall_gtod_data.clock.vread = clock->vread; vsyscall_gtod_data.clock.cycle_last = clock->cycle_last; vsyscall_gtod_data.clock.mask = clock->mask; vsyscall_gtod_data.clock.mult = clock->mult; vsyscall_gtod_data.clock.shift = clock->shift; vsyscall_gtod_data.wall_time_sec = wall_time->tv_sec; vsyscall_gtod_data.wall_time_nsec = wall_time->tv_nsec; <=== vsyscall_gtod_data.sys_tz = sys_tz; vsyscall_gtod_data.wall_time_nsec = wall_time->tv_nsec; <=== vsyscall_gtod_data.wall_to_monotonic = wall_to_monotonic; write_sequnlock_irqrestore(&vsyscall_gtod_data.lock, flags); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |