Messages in this thread | | | Date | Fri, 3 Aug 2007 22:54:08 +0100 | From | Alan Cox <> | Subject | Re: [PATCH -mm] libata: add human-readable error value decoding v3 |
| |
On Fri, 03 Aug 2007 12:00:57 -0600 Robert Hancock <hancockr@shaw.ca> wrote:
> This adds human-readable decoding of the ATA status and error registers > (similar to what drivers/ide does) as well as the SATA Serror register to > libata error handling output. This prevents the need to pore through > standards documents to figure out the meaning of the bits in these > registers when looking at error reports. Some bits that drivers/ide > decoded are not decoded here, since the bits are either command-dependent > or obsolete, and properly parsing them would add too much complexity.
Not sure its really worth it. Does "ABRT IDNF" actually tell you any more than the hex code ? In fact I find the hex code clearer because its usually the combination of state (0x51) etc that tells the story.
No objection to it going in and on a correctness basis
Acked-by: Alan Cox <alan@redhat.com> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |