lkml.org 
[lkml]   [2007]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] hptiop: adding new firmware interface and more PCI device IDs
HighPoint Linux Team wrote:
> + if (hba->firmware_version > 0x01020000 || hba->interface_version > 0x01020000) {
[...]
> + if (hba->firmware_version > 0x01020000 ||
> + hba->interface_version > 0x01020000) {

Rather than repeating this test, you should do it once at probe time,
and set a "new interface" single-bit flag in some hptiop_hba field.

Less maintenance intensive, less prone to error, and removes expensive
tests from the driver hotpath.


> static struct pci_device_id hptiop_id_table[] = {
> - { PCI_DEVICE(0x1103, 0x3220) },
> - { PCI_DEVICE(0x1103, 0x3320) },
> + { PCI_DEVICE(PCI_VENDOR_ID_TTI, 0x3220) },
> + { PCI_DEVICE(PCI_VENDOR_ID_TTI, 0x3320) },
> + { PCI_DEVICE(PCI_VENDOR_ID_TTI, 0x3520) },
> + { PCI_DEVICE(PCI_VENDOR_ID_TTI, 0x4320) },
> {},

Using the PCI_VDEVICE() macro can make this even shorter:

{ PCI_VDEVICE(TTI, 0x4320) }

Regards,

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-08-29 12:59    [W:0.366 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site